Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make the video in song editor draggable, resizable & snappable #85

Merged
merged 11 commits into from
Nov 19, 2024
Merged

feat: make the video in song editor draggable, resizable & snappable #85

merged 11 commits into from
Nov 19, 2024

Conversation

oliver139
Copy link
Collaborator

@oliver139 oliver139 commented Nov 2, 2024 •
edited
Loading

Fix #32

vue3-moveable is used

  • Draggable
  • Resizable
  • Snappable to window edge
  • Re-position on window resize
  • Reset to initial size and location by double clicking the drag handle

Not tested on mobile device yet

@oliver139 oliver139 requested a review from antfu November 2, 2024 15:43
@netlify Netlify
Copy link

netlify bot commented Nov 2, 2024 •
edited
Loading

✅ Deploy Preview for nijuumaru ready!

Name Link
🔨 Latest commit c327c47
🔍 Latest deploy log https://app.netlify.com/sites/nijuumaru/deploys/672a63ba058a0d0008d964b1
😎 Deploy Preview https://deploy-preview-85--nijuumaru.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oliver139 oliver139 changed the title Feat/video drag resize feat: make the video in song editor draggable, resizable & snappable Nov 2, 2024
LittleSound
LittleSound reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@LittleSound LittleSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. but I think the video window should be fixed when scrolling?

@oliver139
Copy link
Collaborator Author

looks good to me. but I think the video window should be fixed when scrolling?

Oh yes, you are right :D
should use a position: fixed here
Let me amend this later

@oliver139
Copy link
Collaborator Author

oliver139 commented Nov 5, 2024 •
edited
Loading

Ok, corrected with some more extra fixes:

  • The video window is now fixed when scrolling
  • max-width & max-height are now applied to avoid the video being larger then the browser window
  • Avoid the video be placed outside the browser window when resetting with double clicking the drag handle

LittleSound
LittleSound approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@LittleSound LittleSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antfu antfu merged commit 0126138 into main Nov 19, 2024
6 checks passed
@antfu antfu deleted the feat/video-drag-resize branch November 19, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleSound LittleSound LittleSound approved these changes

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

可拖拽可調整大小的 Player
3 participants
@oliver139 @LittleSound @antfu